Re-enable the DropWrites Test #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuval-Ariel
approved these changes
Jun 11, 2023
|
@mrambacher the issue seems to have been fixed. plz add a dummy commit to run the "Check TARGETS file and code format" test |
udi-speedb
pushed a commit
that referenced
this pull request
Nov 22, 2023
udi-speedb
pushed a commit
that referenced
this pull request
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not reproduce the problem with the DropWrites test. However, based on the comment and the code, I believe the issue might have been caused by log files counting against the files. I changed the test to only check/count the SST files -- which should be the only ones affected by DropWrites anyway -- and still do not see the problem.
Since I could not reproduce the problem before, it is hard to say for certain that I have addressed the problem. Hopefully running in the CI will now pass the tests more consistently.